Hmmm…I shall take the counter-point of your question on ethics:
Is it ethical for a museum (just using that word as a "catch-all" for all the locations brought up in your post) to use ghost-hunting as a tool to generate revenue? I say yes…categorized as a necessary evil.
I believe that you answered your own question by stating "But it's no secret that in these uncertain economic times, people are spending their travel dollars more conservatively and poorly funded museums and park sites are often hit quite hard." It is about surviving. A museum, first and foremost, is a business. It may be "viewed" as an education institution, but truly it isn't. One of their goals may be to educate. And that's great. But their first goal is to stay open. Your doors close…you ain't educatin' nobody…
So for now this fad, and it is just a fad, helps to pay the bills. Do the museums find it somewhat distasteful to engage in this sort of thing? Probably. But like the saying goes; desperate times call for desperate actions. Yet, their saving grace is this…they can probably slip in some real history, facts, and information along the way. It isn't much, but at least they can probably sleep at night. It is akin to telling a story to a child at night time. One can interweave life lessons and morals into the stories. Same with the museums, they can interweave some reality into a fiction-based tour.
The other question is more difficult to answer. First…the difference between a private home versus a commercial property. I believe that typically a private home with a supposed haunting is actually devalued a bit. I'm way too tired to look right now, but there's a thread in this section that discusses that topic a bit. Finding actual data on this is difficult due to the fact that all the states have different laws and regulations about disclosure and such. Yet, people dying in the home (the supposed genesis of the ghosts haunting the place) is never a great selling point.
As for supporting the theory that commercial properties receive an added jump in revenue from being on a paranormal TV show…well…I would think at least a short term jump is seen. Yet, I wouldn't have the slighest clue on how to prove or disprove that. If someone is interested in looking at public records and matching them up with their appearances on various shows…then have at it. I'd rather watch paint dry than attempt anything like that.
Yet, I believe that one can logically assume that at least a short and small increase in revenue is seen just due to added popularity by being seen on TV, regardless of the show being paranormal or not.